[PATCH] [ARM] Add tests for default value of Tag_ABI_FP_rounding.

Charlie Turner charlie.turner at arm.com
Tue Dec 2 09:39:17 PST 2014


Hi Tim,

> I'm not sure these tests are actually testing what you think they are. the "CHECK-XYZ-NOT" test only applies to the text before the first part that actually is matched.

Build attributes are sorted by their tag number when serialized, so if I say

CHECK-NOT: .eabi_attribute 19, 1
CHECK: .eabi_attribute 20, 0

I know in advance that the file won't contain attributes ordered like

.eabi_attribute 20, 0
.eabi_attribute 19, 1

Have I understood your concern?

Thanks for looking!
Charlie. 








More information about the llvm-commits mailing list