[PATCH] [compiler-rt] Implement AddressSanitizer suppressions

[Alexey Samsonov]

================
Comment at: lib/asan/asan_interceptors.cc:60
@@ +59,3 @@
+          GET_STACK_TRACE_FATAL_HERE;                                   \
+          suppressed = IsStackTraceSuppressed(&stack);                  \
+        }                                                               \
----------------
Please fix this so that you wouldn't need to unwind the stack trace if suppressions of relevant kinds are missing.

================
Comment at: lib/asan/asan_interceptors.cc:129
@@ -115,1 +128,3 @@
 
+struct AsanInterceptorContext {
+  const char *interceptor_name;
----------------
Consider moving this decl above, as it's used above in ACCESS_MEMORY_RANGE macro.

================
Comment at: lib/asan/asan_suppressions.cc:19
@@ +18,3 @@
+#include "sanitizer_common/sanitizer_common.h"
+#include "sanitizer_common/sanitizer_placement_new.h"
+#include "sanitizer_common/sanitizer_stacktrace.h"
----------------
Do you really need all these headers?

================
Comment at: lib/asan/asan_suppressions.cc:25
@@ +24,3 @@
+
+static bool suppressions_inited = false;
+
----------------
Consider checking this flag in Is<..>Suppressed() functions.

http://reviews.llvm.org/D6280