[compiler-rt] r223094 - Add override specifiers to Symbolizer methods. NFC.

Alexey Samsonov vonosmas at gmail.com
Mon Dec 1 15:47:51 PST 2014


Author: samsonov
Date: Mon Dec  1 17:47:51 2014
New Revision: 223094

URL: http://llvm.org/viewvc/llvm-project?rev=223094&view=rev
Log:
Add override specifiers to Symbolizer methods. NFC.

Modified:
    compiler-rt/trunk/lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cc
    compiler-rt/trunk/lib/sanitizer_common/sanitizer_symbolizer_win.cc

Modified: compiler-rt/trunk/lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cc?rev=223094&r1=223093&r2=223094&view=diff
==============================================================================
--- compiler-rt/trunk/lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cc (original)
+++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cc Mon Dec  1 17:47:51 2014
@@ -514,7 +514,7 @@ class POSIXSymbolizer : public Symbolize
         internal_symbolizer_(internal_symbolizer),
         libbacktrace_symbolizer_(libbacktrace_symbolizer) {}
 
-  uptr SymbolizePC(uptr addr, AddressInfo *frames, uptr max_frames) {
+  uptr SymbolizePC(uptr addr, AddressInfo *frames, uptr max_frames) override {
     BlockingMutexLock l(&mu_);
     if (max_frames == 0)
       return 0;
@@ -582,7 +582,7 @@ class POSIXSymbolizer : public Symbolize
     return frame_id;
   }
 
-  bool SymbolizeData(uptr addr, DataInfo *info) {
+  bool SymbolizeData(uptr addr, DataInfo *info) override {
     BlockingMutexLock l(&mu_);
     LoadedModule *module = FindModuleForAddress(addr);
     if (module == 0)
@@ -609,17 +609,17 @@ class POSIXSymbolizer : public Symbolize
   }
 
   bool GetModuleNameAndOffsetForPC(uptr pc, const char **module_name,
-                                   uptr *module_address) {
+                                   uptr *module_address) override {
     BlockingMutexLock l(&mu_);
     return FindModuleNameAndOffsetForAddress(pc, module_name, module_address);
   }
 
-  bool CanReturnFileLineInfo() {
+  bool CanReturnFileLineInfo() override {
     return internal_symbolizer_ != 0 || external_symbolizer_ != 0 ||
            libbacktrace_symbolizer_ != 0;
   }
 
-  void Flush() {
+  void Flush() override {
     BlockingMutexLock l(&mu_);
     if (internal_symbolizer_ != 0) {
       SymbolizerScope sym_scope(this);
@@ -627,7 +627,7 @@ class POSIXSymbolizer : public Symbolize
     }
   }
 
-  const char *Demangle(const char *name) {
+  const char *Demangle(const char *name) override {
     BlockingMutexLock l(&mu_);
     // Run hooks even if we don't use internal symbolizer, as cxxabi
     // demangle may call system functions.
@@ -642,7 +642,7 @@ class POSIXSymbolizer : public Symbolize
     return DemangleCXXABI(name);
   }
 
-  void PrepareForSandboxing() {
+  void PrepareForSandboxing() override {
 #if SANITIZER_LINUX && !SANITIZER_ANDROID
     BlockingMutexLock l(&mu_);
     // Cache /proc/self/exe on Linux.

Modified: compiler-rt/trunk/lib/sanitizer_common/sanitizer_symbolizer_win.cc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_symbolizer_win.cc?rev=223094&r1=223093&r2=223094&view=diff
==============================================================================
--- compiler-rt/trunk/lib/sanitizer_common/sanitizer_symbolizer_win.cc (original)
+++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_symbolizer_win.cc Mon Dec  1 17:47:51 2014
@@ -26,7 +26,7 @@ class WinSymbolizer : public Symbolizer
  public:
   WinSymbolizer() : initialized_(false) {}
 
-  uptr SymbolizePC(uptr addr, AddressInfo *frames, uptr max_frames) {
+  uptr SymbolizePC(uptr addr, AddressInfo *frames, uptr max_frames) override {
     if (max_frames == 0)
       return 0;
 
@@ -85,11 +85,11 @@ class WinSymbolizer : public Symbolizer
     return 1;
   }
 
-  bool CanReturnFileLineInfo() {
+  bool CanReturnFileLineInfo() override {
     return true;
   }
 
-  const char *Demangle(const char *name) {
+  const char *Demangle(const char *name) override {
     CHECK(initialized_);
     static char demangle_buffer[1000];
     if (name[0] == '\01' &&





More information about the llvm-commits mailing list