[lld] r222983 - [Core] Add flag to check if RoundTripPasses need to be run.

[Rui Ueyama]

On Mon, Dec 1, 2014 at 12:11 PM, Shankar Easwaran <shankare at codeaurora.org>
wrote:

> On 12/1/2014 2:04 PM, Rui Ueyama wrote:
>
>> I'm not sure if I got what you mean... So, just to make sure we are on the
>> same page, the reason to have the round-trip passes is to make sure all
>> output can be serialized and de-serialized, right? I think you added these
>> tests because of that reason.
>>
>> Because the YAML/Native are guaranteed compatible, we can dump an
>> intermediate results to YAML/Native files and then resume processing by
>> reading them back.
>>
>> And then looks like you are now adding a way to bypass that. So they are
>> no
>> longer compatible. That is exactly what you wanted to avoid, no?
>>
> Yes, I thought of adding a way to bypass that but you are right, we should
> not allow the RoundTripPasses to be bypassed. I will remove the
> setRunRoundTripPass function in LinkingContext.
>
> But I do need lld to preserve the filename of the atom using references if
> the round trip passes were going to be run. So the reader and the writer
> would read the information using references if the round trip passes were
> being run.


If you need a new property, you can add that to Atom. (Code review would be
needed though.)


>
> Shankar Easwaran
>
>
> --
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted
> by the Linux Foundation
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141201/da9889fe/attachment.html>