[PATCH] ARM: Add support for ARM modified immediate syntax - Take 3

Asiri Rathnayake asiri.rathnayake at arm.com
Mon Dec 1 10:22:58 PST 2014


Hi Tim,

> ================
> Comment at: lib/Target/ARM/InstPrinter/ARMInstPrinter.cpp:1332-1338
> @@ +1331,9 @@
> +
> +  if (Rot == 0) {
> +    O << "#"
> +      << markup("<imm:")
> +      << Bits
> +      << markup(">");
> +    return;
> +  }
> +
> ----------------
> Isn't this now redundant? Looks like it would be covered fine by the logic below.
>

Thanks for the catch!

I've attached an updated patch.

--Asiri







More information about the llvm-commits mailing list