[PATCH] [Sanitizer][MIPS] internal_stat for mips64

Mohit Bhakkad mohit.bhakkad at imgtec.com
Mon Dec 1 02:02:50 PST 2014


================
Comment at: lib/sanitizer_common/sanitizer_linux.cc:40
@@ +39,3 @@
+
+// For mips64, stat syscall fills buffer in the format of kernel_stat
+// structure kernel_stat is defined as stat in asm/stat.h
----------------
samsonov wrote:
> Please turn this comment into a few regular english sentences with proper punctuation. It's hard to understand it otherwise.
Hi @samsonov, is it OK to write it like:


```
/* For mips64, syscall(__NR_stat) fills the buffer in the 'struct kernel_stat' format. 
   Struct kernel_stat is defined as 'struct stat' in asm/stat.h. To access stat from 
   asm/stat.h, without conflicting with definition in sys/stat.h, we use this trick. */
```

http://reviews.llvm.org/D6385






More information about the llvm-commits mailing list