[PATCH] Added InstCombine transformation for combining two instructions icmp ult/ule/uge/ugt (ashr/lshr (Const2) %A), (Const1)

Ankur Garg ankur29.garg at samsung.com
Sun Nov 30 22:52:10 PST 2014


Hi David, 
Thanks for reviewing the patch. I have made the changes as per your comments.

About the change from ConstantInt to APInt:
There are two ConstantInt variables 'CI' and 'CI2'. The variable 'CI' is being used elsewhere too. Should I make this change ? And CI2 is being used in 2 other functions. Both these functions right now, expect ConstantInt. Should I change it for all the functions ?

Thanks.

http://reviews.llvm.org/D5518

Files:
  lib/Transforms/InstCombine/InstCombine.h
  lib/Transforms/InstCombine/InstCombineCompares.cpp
  test/Transforms/InstCombine/icmp-shr.ll
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D5518.16755.patch
Type: text/x-patch
Size: 12350 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141201/dc49f774/attachment.bin>


More information about the llvm-commits mailing list