[PATCH] Add ARM ERET and HVC virtualisation extension instructions.

Tim Northover t.p.northover at gmail.com
Fri Nov 28 10:28:10 PST 2014


Hi Charlie,

I think this looks fine, with one exception (which looks OK too, but is in the wrong patch).

Cheers.

Tim.

REPOSITORY
  rL LLVM

================
Comment at: lib/Target/ARM/InstPrinter/ARMInstPrinter.cpp:295-298
@@ +294,6 @@
+  }
+    // B9.3.3 ERET (Thumb)
+    // For a target that has Virtualization Extensions, ERET is the preferred
+    // disassembly of SUBS PC, LR, #0
+  case ARM::t2SUBS_PC_LR: {
+    if (MI->getNumOperands() == 3 &&
----------------
This is Thumb handling code. Shouldn't it be in the other patch?

http://reviews.llvm.org/D6449






More information about the llvm-commits mailing list