[PATCH] Add Thumb HVC and ERET virtualisation extension instructions.

Tim Northover t.p.northover at gmail.com
Fri Nov 28 06:45:13 PST 2014


================
Comment at: test/MC/Disassembler/ARM/virtexts-thumb.txt:20-23
@@ +19,6 @@
+#------------------------------------------------------------------------------
+# ERET is the prefered form for SUBS PC, LR, #0 for cores that support
+# virtualization extensions. The ARM backend currently has problems with
+# printing instruction aliases. Until that is fixed, ERET will be emitted as
+# SUBS PC, LR, #0.
+
----------------
Is this comment consistent with what you're actually checking? It looks like we are successfully emitting ERET now if this test passes.

http://reviews.llvm.org/D6450






More information about the llvm-commits mailing list