[PATCH] [MSan][LLVM][MIPS] Shadow and Origin offsets for MIPS

Evgeniy Stepanov eugenis at google.com
Fri Nov 28 04:43:46 PST 2014


LGTM with 1 more comment

================
Comment at: lib/Transforms/Instrumentation/MemorySanitizer.cpp:125
@@ +124,3 @@
+static const uint64_t kX86_64ShadowMask = 1ULL << 46;
+static const uint64_t kMIPS64_ShadowMask = 0x4000000000ULL;
+static const uint64_t kX86OriginOffset = 1ULL << 30;
----------------
Please remove the extra underscore after MIPS64 and change the constant to 1ULL << (something) for consistency.

http://reviews.llvm.org/D6146






More information about the llvm-commits mailing list