[llvm] r222897 - Commit back the correct bits of r222760 (was r222538).

Joerg Sonnenberger joerg at britannica.bec.de
Thu Nov 27 14:19:12 PST 2014


On Thu, Nov 27, 2014 at 04:44:31PM -0500, Rafael EspĂ­ndola wrote:
> > But your change reverts JIT to the old broken status.
> 
> It is common practice to revert a patch when they broke something.
> 
> Your patch broke mc and changed the tests. I have reverted it added
> back the fix for when using the large code model. You are more than
> welcome to debug why Default and JITDefault get this far, as that is
> probably the correct way to fix the JIT issue you were seeing.

That doesn't justify committing an obviously not working patch either.

Joerg



More information about the llvm-commits mailing list