[PATCH] [MSan][LLVM][MIPS] Shadow and Origin offsets for MIPS

Evgeniy Stepanov eugenis at google.com
Thu Nov 27 06:36:16 PST 2014


LGTM w/ nit

================
Comment at: lib/Transforms/Instrumentation/MemorySanitizer.cpp:123
@@ -122,3 +122,3 @@
 
 static const uint64_t kShadowMask32 = 1ULL << 31;
 static const uint64_t kShadowMask64 = 1ULL << 46;
----------------
Please change it to kX86_64ShadowMask, kX86ShadowMask, etc (the same for origin offset below).

================
Comment at: lib/Transforms/Instrumentation/MemorySanitizer.cpp:125
@@ -124,2 +124,3 @@
 static const uint64_t kShadowMask64 = 1ULL << 46;
+static const uint64_t kMIPS64_ShadowMask64 = 0x4000000000ULL;
 static const uint64_t kOriginOffset32 = 1ULL << 30;
----------------
No need for the "64" suffix, it already says "MIPS64".

http://reviews.llvm.org/D6146






More information about the llvm-commits mailing list