[PATCH] [Compiler-rt][Sanitizer][MSan][i386] Adding support for i386

Evgeniy Stepanov eugenis at google.com
Thu Nov 27 05:04:17 PST 2014


Ah, OK. In ASan tests there is code (in lit.cfg)  that adds -m32 or -m64 to %clangxx depending on the test suite configuration, could you copy that to msan and remove hardcoded -m64?

Please don't forget about msan_test.cc.

I'm sure you'll run into issues with va-arg functions: see VarArgAMD64Helper in MemorySanitizer.cpp, it needs to be reimplemented for i386 and probably both MIPS variants. Tests for that are in msan_test.cc.

http://reviews.llvm.org/D6433






More information about the llvm-commits mailing list