[PATCH] Simplify Symbolizer::SymbolizePC() interface.

Dmitry Vyukov dvyukov at google.com
Wed Nov 26 23:09:06 PST 2014


================
Comment at: lib/sanitizer_common/sanitizer_symbolizer.cc:56
@@ +55,3 @@
+    next->ClearAll();
+    next = nullptr;
+  }
----------------
who is deallocating next?

================
Comment at: lib/tsan/rtl/tsan_rtl_report.cc:75
@@ -75,1 +74,3 @@
+    last_frame->ClearAll();
+    last_frame2->next = nullptr;
   // Strip our internal thread start routine.
----------------
who is deallocating last_frame?
here and below

================
Comment at: lib/tsan/rtl/tsan_symbolize.cc:58
@@ -57,3 +57,3 @@
 
-ReportStack *SymbolizeCode(uptr addr) {
+SymbolizedFrame *SymbolizeCode(uptr addr) {
   // Check if PC comes from non-native land.
----------------
SymbolizedFrame is somewhat confusing here, because it is whole stack rather than a single frame.
I would s/SymbolizedFrame/SymbolizedStack/

http://reviews.llvm.org/D6394






More information about the llvm-commits mailing list