[PATCH] Fix Windows build

[Sean Silva]

I have attached the output with a git-svn repo on Mac. Looks fine (except
for the awkwardness of calling the macros SVN_REVISION and SVN_REPOSITORY;
could you change the name of those in a follow-on patch?).

-- Sean Silva

On Wed, Nov 26, 2014 at 5:09 PM, Robinson, Paul <
Paul_Robinson at playstation.sony.com> wrote:

> Revised patch that I'm pretty sure will handle straight git.
> I'd appreciate somebody trying it with a git-svn clone, though.
> Thanks,
> --paulr
>
> > -----Original Message-----
> > From: Robinson, Paul
> > Sent: Wednesday, November 26, 2014 4:15 PM
> > To: Robinson, Paul; llvm-commits at cs.uiuc.edu
> > Subject: RE: [PATCH] Fix Windows build
> >
> > With patch...
> >
> > > -----Original Message-----
> > > From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-
> > > bounces at cs.uiuc.edu] On Behalf Of Robinson, Paul
> > > Sent: Wednesday, November 26, 2014 4:12 PM
> > > To: llvm-commits at cs.uiuc.edu
> > > Subject: [PATCH] Fix Windows build
> > >
> > > r222391 updated GetSVN.cmake to run the LLVM helper scripts
> > > GetSourceVersion
> > > and GetRepositoryPath.  However, being shell scripts, they work only on
> > > Unix-y hosts; on Windows they don't work, you end up with an
> > > SVNVersion.inc
> > > that looks like this:
> > >
> > > #define LLVM_REVISION ""
> > > #define LLVM_REPOSITORY ""
> > > #define SVN_REVISION ""
> > > #define SVN_REPOSITORY ""
> > >
> > > I've rewritten the scripts as best I can into CMake so they will work
> on
> > > Windows as well.  Now I get a better-looking SVNVersion.inc:
> > >
> > > #define LLVM_REVISION "222770"
> > > #define LLVM_REPOSITORY "http://llvm.org/svn/llvm-project/llvm/trunk"
> > > #define SVN_REVISION "222770"
> > > #define SVN_REPOSITORY "http://llvm.org/svn/llvm-project/cfe/trunk"
> > >
> > > I can only test it on SVN, but I was able to clone code from another
> > > CMake script so I'm pretty hopeful that it works for Git as well.
> > >
> > > Thanks,
> > > --paulr
> > >
> > >
> > > _______________________________________________
> > > llvm-commits mailing list
> > > llvm-commits at cs.uiuc.edu
> > > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141126/aee024a3/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: SVNVersion.inc
Type: application/octet-stream
Size: 239 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141126/aee024a3/attachment.obj>