[PATCH] Simplify Symbolizer::SymbolizePC() interface.
Sergey Matveev
earthdok at google.com
Wed Nov 26 05:40:48 PST 2014
================
Comment at: lib/sanitizer_common/sanitizer_symbolizer_libbacktrace.cc:86
@@ -85,2 +85,3 @@
struct SymbolizeCodeData {
+ SymbolizedFrame *res;
----------------
We have SymbolizeCode(), SymbolizeData() and struct SymbolizeCodeData. Confusing. Besides, "Data" doesn't really tell you anything. This should be renamed to something like SymbolizeCodeResult.
================
Comment at: lib/sanitizer_common/sanitizer_symbolizer_libbacktrace.cc:87
@@ -86,4 +86,3 @@
struct SymbolizeCodeData {
- AddressInfo *frames;
- uptr n_frames;
- uptr max_frames;
+ SymbolizedFrame *res;
+ SymbolizedFrame *last;
----------------
I'm not happy with this name. Maybe "result" or "first"? I'd prefer the latter.
http://reviews.llvm.org/D6394
More information about the llvm-commits
mailing list