[llvm] r222746 - R600/SI: Disable commutativity for MIN/MAX_LEGACY

[Matt Arsenault]

> On Nov 25, 2014, at 6:16 AM, Marek Olšák <maraeo at gmail.com> wrote:
> 
> Thanks. I'll need to discuss with Matt whether and how those tests
> should be fixed (which suggests that they were wrong from the
> beginning).
> 
> Sorry for the breakage.
> 
> Marek

It’s possible that the tests happen to currently be correct. I can just merge this patch in with mine which fixes incorrectly matching the wrong order in the unordered cases




> 
> On Tue, Nov 25, 2014 at 11:47 AM, Chandler Carruth <chandlerc at google.com> wrote:
>> On Tue, Nov 25, 2014 at 2:16 AM, Chandler Carruth <chandlerc at google.com>
>> wrote:
>>> 
>>> 
>>> On Tue, Nov 25, 2014 at 1:49 AM, Marek Olsak <marek.olsak at amd.com> wrote:
>>>> 
>>>> Author: mareko
>>>> Date: Tue Nov 25 03:49:23 2014
>>>> New Revision: 222746
>>>> 
>>>> URL: http://llvm.org/viewvc/llvm-project?rev=222746&view=rev
>>>> Log:
>>>> R600/SI: Disable commutativity for MIN/MAX_LEGACY
>>>> 
>>>> Modified:
>>>>    llvm/trunk/lib/Target/R600/SIInstructions.td
>>> 
>>> 
>>> You seem to have not updated the tests:
>>> 
>>> 
>>> http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-debian-fast/builds/20003
>>> 
>>> Please fix or revert soon!
>> 
>> 
>> OK, 30 minutes since my email and much longer since the first bot went red.
>> I'm reverting this.
>> 
>> Please watch the build bots and check that your changes don't break things
>> before re-committing... =[
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits