[llvm] r221870 - Object, COFF: getRelocationSymbol shouldn't assert
David Majnemer
david.majnemer at gmail.com
Mon Nov 24 23:29:24 PST 2014
This used to be possible but r222124 added a check to see that we couldn't
have a null pointer to a symbol and a non-zero number of symbols. I'll add
the call to llvm_unreachable back.
On Mon, Nov 24, 2014 at 11:17 PM, Rafael EspĂndola <
rafael.espindola at gmail.com> wrote:
> Ping. This is still untested. I just checked that the attached revert
> passes all tests.
>
> On 20 November 2014 at 09:36, Rafael EspĂndola
> <rafael.espindola at gmail.com> wrote:
> >> I've added a test in r222413.
> >
> > It doesn't look like it covers the case of an object not having a
> > symbol table. I.E., the change in COFFObjectFile.cpp is still
> > untested, no?
> >
> > Cheers,
> > Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141125/cb2613d7/attachment.html>
More information about the llvm-commits
mailing list