[PATCH] Drop Cloog support

Tobias Grosser tobias at grosser.es
Mon Nov 24 23:24:04 PST 2014


Great,

this removes a lot of old code. Thanks Johannes for going through all the documentation and website.

Regarding the old CLooG tests. When we have written the isl backend we went through them already once and ported the tests we considered important. The same was true when the OpenMP backend was added. So many important tests are already ported. Just moving all of them to isl will just give us many redundant tests. We could possibly go through them 1-by-1, but I don't have the feeling we would loose too much test coverage if we just drop them.

LGTM, if tested (and the scoplib changes are removed)

================
Comment at: configure:598
@@ -594,1 +597,3 @@
+scoplib_inc
+scoplib_found
 pluto_ld
----------------
scoplib sneaked back in for whatever reason.

================
Comment at: configure:666
@@ -665,2 +665,3 @@
 with_pluto
+with_scoplib
 enable_polly_gpu_codegen
----------------
Why is scoplib back?

================
Comment at: configure:1299
@@ -1298,2 +1298,3 @@
   --with-pluto            prefix of pluto
+  --with-scoplib          prefix of scoplib
   --with-cuda             prefix of cuda
----------------
Why is scoplib back?

================
Comment at: configure:2679
@@ -2682,3 +2678,3 @@
 
-  LIBS="$LIBS -lpluto";
+  LIBS="$LIBS -lscoplib";
 
----------------
Why scoplib again?

================
Comment at: www/documentation/gpgpucodegen.html:125
@@ -124,3 +124,3 @@
 opt -load /path/to/polly/build/LLVMPolly.so -basicaa -polly-import-jscop
-    -polly-cloog -analyze -q ./test.ll
+    -polly-ast -analyze -q ./test.ll
     -polly-import-jscop-postfix=transformed+gpu
----------------
The old GPGPU codegen onlyworked with the CLooG backend. No need to update it. We can drop it as well (possibly in a later commit).

http://reviews.llvm.org/D6400






More information about the llvm-commits mailing list