[PATCH] MC: Don't emit min version directives when -fno-integrated-as is on

[Jim Grosbach]

IMO, yes. Perhaps better would be repurposing it to emit at least a warning in the driver so folks know what to expect, though. 

Sent from my iPad

> On Nov 23, 2014, at 11:38 AM, David Majnemer <david.majnemer at gmail.com> wrote:
> 
> Should the bug be closed as won't fix?
> 
> Sent from my phone
> 
>> On Saturday, November 22, 2014, Jim Grosbach <grosbach at apple.com> wrote:
>> The non integrated assembler can't handle lots of things the compiler emits on Darwin. The only realistic use of that command line option now is when processing .s files.
>> 
>> Sent from my iPad
>> 
>> > On Nov 22, 2014, at 9:29 AM, David Majnemer <david.majnemer at gmail.com> wrote:
>> >
>> > Hi grosbach,
>> >
>> > The assembler included with cctools doesn't understand
>> > .macosx_version_min.  We shouldn't try to emit that directive if we
>> > aren't going to use the integrated assembler.
>> >
>> > This fixes PR21636.
>> >
>> > http://reviews.llvm.org/D6371
>> >
>> > Files:
>> >  lib/CodeGen/AsmPrinter/AsmPrinter.cpp
>> >  test/MC/MachO/no-integrated-as.ll
>> > <D6371.16527.patch>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141123/7c270cee/attachment.html>