[PATCH] MC: Don't emit min version directives when -fno-integrated-as is on

David Blaikie dblaikie at gmail.com
Sat Nov 22 11:15:26 PST 2014


>>! In D6371#6, @majnemer wrote:
>>>! In D6371#4, @dblaikie wrote:
>> I believe we've been trying to avoid special casing the integrated
>> assembler as much as possible (I think Rafael removed many instances of
>> this) - any other signal that would be appropriate to use?
> 
> This patch is working around a directive which the cctools assembler does not have.  Asking it to trigger on another condition would essentially be a proxy for "MC is targeting the cctools assembler" anyway.

Could we do this down in the MCStreamer instead? 

It looks like MCAsmStreamer::EmitVersionMin should just be a no-op, maybe? (or a no-op on Darwin? Is the version directive valid anywhere else other than LLVM's integrated assembler?)

http://reviews.llvm.org/D6371






More information about the llvm-commits mailing list