[PATCH] Add VSX loads/stores to fastisel for PPC target
hfinkel at anl.gov
hfinkel at anl.gov
Thu Nov 20 19:28:11 PST 2014
You have formatting to fix, otherwise LGTM.
In case you did not know, you can run clang-format directly on your patch file.
================
Comment at: /home/seurer/llvm/llvm-oneoff/lib/Target/PowerPC/PPCFastISel.cpp:489
@@ +488,3 @@
+
+ // If this is a potential VSX load with an offset of 0 a VSX indexed load can
+ // be used.
----------------
Comma after 0.
================
Comment at: /home/seurer/llvm/llvm-oneoff/lib/Target/PowerPC/PPCFastISel.cpp:490
@@ +489,3 @@
+ // If this is a potential VSX load with an offset of 0 a VSX indexed load can
+ // be used.
+ bool IsVSFRC = (ResultReg != 0) && isVSFRCRegister (ResultReg);
----------------
Extra space before 'be'
================
Comment at: /home/seurer/llvm/llvm-oneoff/lib/Target/PowerPC/PPCFastISel.cpp:491
@@ +490,3 @@
+ // be used.
+ bool IsVSFRC = (ResultReg != 0) && isVSFRCRegister (ResultReg);
+ if (IsVSFRC && (Opc == PPC::LFD) &&
----------------
No space after isVSFRCRegister.
================
Comment at: /home/seurer/llvm/llvm-oneoff/lib/Target/PowerPC/PPCFastISel.cpp:506
@@ -492,1 +505,3 @@
+ // VSX only provides an indexed load.
+ if (IsVSFRC && Opc==PPC::LFD) return false;
----------------
Add spaces around ==.
================
Comment at: /home/seurer/llvm/llvm-oneoff/lib/Target/PowerPC/PPCFastISel.cpp:520
@@ -504,1 +519,3 @@
+ // VSX only provides an indexed load.
+ if (IsVSFRC && Opc==PPC::LFD) return false;
----------------
Add spaces around ==.
================
Comment at: /home/seurer/llvm/llvm-oneoff/lib/Target/PowerPC/PPCFastISel.cpp:622
@@ -604,1 +621,3 @@
+ // If this is a potential VSX store with an offset of 0 a VSX indexed store
+ // can be used.
----------------
Comma after 0.
================
Comment at: /home/seurer/llvm/llvm-oneoff/lib/Target/PowerPC/PPCFastISel.cpp:623
@@ +622,3 @@
+ // If this is a potential VSX store with an offset of 0 a VSX indexed store
+ // can be used.
+ bool IsVSFRC = isVSFRCRegister (SrcReg);
----------------
Extra space before 'be'.
================
Comment at: /home/seurer/llvm/llvm-oneoff/lib/Target/PowerPC/PPCFastISel.cpp:636
@@ +635,3 @@
+ // VSX only provides an indexed store.
+ if (IsVSFRC && Opc==PPC::STFD) return false;
+
----------------
Add spaces around ==.
================
Comment at: /home/seurer/llvm/llvm-oneoff/lib/Target/PowerPC/PPCFastISel.cpp:653
@@ +652,3 @@
+ // VSX only provides an indexed store.
+ if (IsVSFRC && Opc==PPC::STFD) return false;
+
----------------
Add spaces around ==.
http://reviews.llvm.org/D6274
More information about the llvm-commits
mailing list