[PATCH] [ASan] Fix leak tests on 64-bit targets other than x86-64

Sergey Matveev earthdok at google.com
Wed Nov 19 13:40:57 PST 2014


================
Comment at: test/asan/lit.cfg:126
@@ -127,1 +125,3 @@
+# Turn on leak detection on x86_64 Linux.
+if config.host_os == 'Linux' and config.host_arch == 'x86_64':
   config.environment['ASAN_OPTIONS'] = 'detect_leaks=1'
----------------
samsonov wrote:
> earthdok wrote:
> > foad wrote:
> > > earthdok wrote:
> > > > Sorry, I thought Alexey had taken over this review.
> > > > 
> > > > Is there any way we could get rid of the code duplication between test/asan/lit.cfg and test/asan/Unit/lit.site.cfg.in?
> > > I agree it would be nice to get rid of the duplication, but I don't feel confident enough with lit configuration to do it myself. Maybe it belongs in test/lit.common.cfg?
> > That makes sense to me. Alexey?
> Hm? Doesn't "leak-detection" feature make sense only for ASan tests? Unfortunately, configs for lit-tests and unit tests are different. I'd submit the change as-is.
MSan as well, eventually. Any tool that does not support it will simply not have any tests that depend on this feature.

http://reviews.llvm.org/D6189






More information about the llvm-commits mailing list