[llvm] r219010 - Revert "Revert "DI: Fold constant arguments into a single MDString""

[Frédéric Riss]

> On Nov 19, 2014, at 8:00 AM, Frédéric Riss <friss at apple.com> wrote:
> 
>> 
>> On Nov 19, 2014, at 4:40 AM, Evgeniy Stepanov <eugeni.stepanov at gmail.com <mailto:eugeni.stepanov at gmail.com>> wrote:
>> 
>> It looks like r219010 or one of the related commits may be the cause
>> of this memory leak:
>> http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/5116/steps/check-clang%20asan/logs/stdio <http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/5116/steps/check-clang%20asan/logs/stdio>
> 
> This looks related to the debug info for forward declarations that I finished committing a couple of days ago. I don’t think it is related to Duncan’s work. I’ll take a look.

Hopefully fixed by cfe commit r222373.

> Fred
> 
>> The bot was down for a long time, so we don't have a better
>> indication, and ownership of MDNode objects is a bit unclear in this
>> code. Could you take a look please?
>> 
>> 
>> On Sat, Oct 4, 2014 at 7:20 PM, Duncan P. N. Exon Smith
>> <dexonsmith at apple.com <mailto:dexonsmith at apple.com>> wrote:
>>> 
>>>> On 2014 Oct 3, at 17:37, Adrian Prantl <aprantl at apple.com <mailto:aprantl at apple.com>> wrote:
>>>> 
>>>> 
>>>>> On Oct 3, 2014, at 5:34 PM, Duncan P. N. Exon Smith <dexonsmith at apple.com <mailto:dexonsmith at apple.com>> wrote:
>>>>> 
>>>>> Oops!  Updating that document was faster than I expected.  This must
>>>>> be why.
>>>>> 
>>>>> Looking more closely, the examples don't seem better than looking
>>>>> directly at `include/llvm/IR/DebugInfo.h` and `lib/IR/DIBuilder.cpp`.
>>>>> 
>>>>> In the attached patch, I update a few of them, but prune the rest, and
>>>>> point the reader at the appropriate place in the source.
>>>>> 
>>>>> Thoughts?
>>>> 
>>>> Looks like you found a way to reduce the maintenance effort while increasing the accuracy of the documentation. I won’t complain :-)
>>> 
>>> r219051
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu <mailto:llvm-commits at cs.uiuc.edu>
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu <mailto:llvm-commits at cs.uiuc.edu>
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu <mailto:llvm-commits at cs.uiuc.edu>
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits <http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141119/6ceb42c3/attachment.html>