[PATCH] Improve RegisterCoalescer debugging experience
Quentin Colombet
qcolombet at apple.com
Wed Nov 19 09:43:09 PST 2014
Hi Matthias,
Thanks for working on this.
Here are my comments.
> 0001-Introduce-register-dump-helper.patch
I do not see in what dumpReg simplifies debugging compared to PrintReg.
Could you elaborate why do you think it is useful?
> 0002-When-multiple-debug-only-arguments-are-specified-han.patch
LGTM, though I would do a separate thread for this so that it gets more people attention.
> 0003-MachineVerifier-Report-register-for-bad-liveranges.patch
LGTM.
> 0004-Add-a-print-and-verify-pass-after-the-RegisterCoales.patch
LGTM.
> 0005-RegisterCoalescer-Improve-debug-messages.patch
LGTM.
Thanks again,
-Quentin
On Nov 18, 2014, at 7:20 PM, Matthias Braun <matze at braunis.de> wrote:
> Attached are 5 simple patches that improve the experience when debugging problems in the RegisterCoalescer.
>
> Greetings
> Matthias
> <0001-Introduce-register-dump-helper.patch><0002-When-multiple-debug-only-arguments-are-specified-han.patch><0003-MachineVerifier-Report-register-for-bad-liveranges.patch><0004-Add-a-print-and-verify-pass-after-the-RegisterCoales.patch><0005-RegisterCoalescer-Improve-debug-messages.patch>
More information about the llvm-commits
mailing list