[llvm] r221915 - Object, Mach-O: Refactor and clean code up

Rafael EspĂ­ndola rafael.espindola at gmail.com
Tue Nov 18 18:04:19 PST 2014


> -      assert(!DataInCodeLoadCmd && "Multiple data in code tables");
> +      // Multiple data in code tables
> +      if (DataInCodeLoadCmd) {
> +        EC = object_error::parse_failed;
> +        return;
> +      }

Do you have a testcase for this? As with COFF, an assert/unreachable
is better unless we have a test showing how this is actually reached.

Cheers,
Rafael



More information about the llvm-commits mailing list