[llvm] r221870 - Object, COFF: getRelocationSymbol shouldn't assert

[Rafael Espíndola]

On 13 November 2014 02:42, David Majnemer <david.majnemer at gmail.com> wrote:
> Author: majnemer
> Date: Thu Nov 13 01:42:11 2014
> New Revision: 221870
>
> URL: http://llvm.org/viewvc/llvm-project?rev=221870&view=rev
> Log:
> Object, COFF: getRelocationSymbol shouldn't assert
>
> lib/Object is supposed to be robust to malformed object files.  Don't
> assert if we don't have a symbol table.  I'll try to come up with a test
> case later.

Ping. Testing the error cases is fairly important so that we have
confidence when re factoring the error handling.

In this particular case, are you sure the code is actually reachable?
We should have rejected the file when opening it, no?

I would much prefer to keep the llvm_unreachable if you cannot create
a testcase.

Cheers,
Rafael