[llvm] r222272 - [FastISel][AArch64] Also allow folding of sign-/zero-extend and arithmetic

Juergen Ributzka juergen at apple.com
Tue Nov 18 16:08:23 PST 2014


Thanks Chad :)

—Juergen

> On Nov 18, 2014, at 2:41 PM, Chad Rosier <mcrosier at codeaurora.org> wrote:
> 
> Author: mcrosier
> Date: Tue Nov 18 16:41:49 2014
> New Revision: 222272
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=222272&view=rev
> Log:
> [FastISel][AArch64] Also allow folding of sign-/zero-extend and arithmetic
> shift-right for booleans (i1).
> 
> Arithmetic shift-right immediate with sign-/zero-extensions also works for
> boolean values.  Update the assert and the test cases to reflect that fact.
> 
> Modified:
>    llvm/trunk/lib/Target/AArch64/AArch64FastISel.cpp
>    llvm/trunk/test/CodeGen/AArch64/fast-isel-shift.ll
> 
> Modified: llvm/trunk/lib/Target/AArch64/AArch64FastISel.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AArch64/AArch64FastISel.cpp?rev=222272&r1=222271&r2=222272&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Target/AArch64/AArch64FastISel.cpp (original)
> +++ llvm/trunk/lib/Target/AArch64/AArch64FastISel.cpp Tue Nov 18 16:41:49 2014
> @@ -4117,8 +4117,9 @@ unsigned AArch64FastISel::emitASR_ri(MVT
>                                      bool IsZExt) {
>   assert(RetVT.SimpleTy >= SrcVT.SimpleTy &&
>          "Unexpected source/return type pair.");
> -  assert((SrcVT == MVT::i8 || SrcVT == MVT::i16 || SrcVT == MVT::i32 ||
> -          SrcVT == MVT::i64) && "Unexpected source value type.");
> +  assert((SrcVT == MVT::i1 || SrcVT == MVT::i8 || SrcVT == MVT::i16 ||
> +          SrcVT == MVT::i32 || SrcVT == MVT::i64) &&
> +         "Unexpected source value type.");
>   assert((RetVT == MVT::i8 || RetVT == MVT::i16 || RetVT == MVT::i32 ||
>           RetVT == MVT::i64) && "Unexpected return value type.");
> 
> 
> Modified: llvm/trunk/test/CodeGen/AArch64/fast-isel-shift.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/AArch64/fast-isel-shift.ll?rev=222272&r1=222271&r2=222272&view=diff
> ==============================================================================
> --- llvm/trunk/test/CodeGen/AArch64/fast-isel-shift.ll (original)
> +++ llvm/trunk/test/CodeGen/AArch64/fast-isel-shift.ll Tue Nov 18 16:41:49 2014
> @@ -1,5 +1,54 @@
> ; RUN: llc -fast-isel -fast-isel-abort -mtriple=aarch64-apple-darwin -verify-machineinstrs < %s | FileCheck %s
> 
> +; CHECK-LABEL: asr_zext_i1_i16
> +; CHECK:       uxth {{w[0-9]*}}, wzr
> +define zeroext i16 @asr_zext_i1_i16(i1 %b) {
> +  %1 = zext i1 %b to i16
> +  %2 = ashr i16 %1, 1
> +  ret i16 %2
> +}
> +
> +; CHECK-LABEL: asr_sext_i1_i16
> +; CHECK:       sbfx [[REG1:w[0-9]+]], {{w[0-9]*}}, #0, #1
> +; CHECK-NEXT:  sxth {{w[0-9]*}}, [[REG1]]
> +define signext i16 @asr_sext_i1_i16(i1 %b) {
> +  %1 = sext i1 %b to i16
> +  %2 = ashr i16 %1, 1
> +  ret i16 %2
> +}
> +
> +; CHECK-LABEL: asr_zext_i1_i32
> +; CHECK:       mov {{w[0-9]*}}, wzr
> +define i32 @asr_zext_i1_i32(i1 %b) {
> +  %1 = zext i1 %b to i32
> +  %2 = ashr i32 %1, 1
> +  ret i32 %2
> +}
> +
> +; CHECK-LABEL: asr_sext_i1_i32
> +; CHECK:       sbfx  {{w[0-9]*}}, {{w[0-9]*}}, #0, #1
> +define i32 @asr_sext_i1_i32(i1 %b) {
> +  %1 = sext i1 %b to i32
> +  %2 = ashr i32 %1, 1
> +  ret i32 %2
> +}
> +
> +; CHECK-LABEL: asr_zext_i1_i64
> +; CHECK:       mov {{x[0-9]*}}, xzr
> +define i64 @asr_zext_i1_i64(i1 %b) {
> +  %1 = zext i1 %b to i64
> +  %2 = ashr i64 %1, 1
> +  ret i64 %2
> +}
> +
> +; CHECK-LABEL: asr_sext_i1_i64
> +; CHECK:       sbfx {{x[0-9]*}}, {{x[0-9]*}}, #0, #1
> +define i64 @asr_sext_i1_i64(i1 %b) {
> +  %1 = sext i1 %b to i64
> +  %2 = ashr i64 %1, 1
> +  ret i64 %2
> +}
> +
> ; CHECK-LABEL: lsr_zext_i1_i16
> ; CHECK:       uxth {{w[0-9]*}}, wzr
> define zeroext i16 @lsr_zext_i1_i16(i1 %b) {
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits





More information about the llvm-commits mailing list