[PATCH] Make the MachineVerifier accept single landingpad successors (Was: [LLVMdev] Should the MachineVerifier accept a MBB with a single (landing pad) successor?)

Ahmed Bougacha ahmed.bougacha at gmail.com
Tue Nov 18 07:11:08 PST 2014


Thanks Tim!

If there are no objections, I'll commit this by next week.

- Ahmed


On Thu, Nov 13, 2014 at 9:49 PM, Tim Northover <t.p.northover at gmail.com> wrote:
> Hi Ahmed,
>
> On 12 November 2014 10:47, Ahmed Bougacha <ahmed.bougacha at gmail.com> wrote:
>>> I've been investigating a machine verifier failure on the attached
>>> testcase, and I'm tempted to say the verifier is wrong and should
>>> accept it.  Skip the description for the proposed change.
>
> I think you made a fair case. Each step along the way seems
> reasonable, so the IR ought to be valid. I don't think we want to be
> guaranteeing redundant branches will be removed, which is the only
> other realistic solution.
>
> Cheers.
>
> Tim.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: machineverifier_lpad_succ.patch
Type: application/octet-stream
Size: 6265 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141118/d9fa72d0/attachment.obj>


More information about the llvm-commits mailing list