[PATCH] [AArch64] Customer lowering of CTPOP to SIMD should check for NEON availability

Tim Northover t.p.northover at gmail.com
Mon Nov 17 15:20:08 PST 2014


Hi,

The change itself looks reasonable, but I think the tests could be improved:

================
Comment at: test/CodeGen/AArch64/arm64-popcnt.ll:12
@@ -10,2 +11,3 @@
 ; CHECK: ret
+; CHECK-NONEON-NOT: 8b
 }
----------------
Can we check that what actually is produced is sensible? Purely negative tests are discouraged when alternatives are possible.

http://reviews.llvm.org/D6299






More information about the llvm-commits mailing list