[PATCH] Fully handle globals and functions in CGDebugInfo::getDeclarationOrDefinition()

[David Blaikie]

================
Comment at: lib/CodeGen/CGDebugInfo.cpp:2310
@@ -2309,1 +2309,3 @@
 
+void CGDebugInfo::collectFunctionDeclProps(GlobalDecl GD,
+                                           llvm::DIFile Unit,
----------------
friss wrote:
> dblaikie wrote:
> > dblaikie wrote:
> > > If you want to submit these refactorings separately, feel free (& do that sort of thing without precommit review - just pulling out a bit of functionality and giving it a name is usually goodness even before the second user exists (we tend to have long functions that are hard to read - pulling out parts of them and giving them names usually makes them a bit easier to follow) - and it makes the code reviews more palatable (I can easily glance at a single function refactor like this, and mostly just assume you did the obvious thing of copy/paste the code and give it a name))
> > Though the name 'collect' might be different from the existing similar functions we have for subprograms - could you check if we can have a more consistent naming one way or the other? (I think I named the subprogram ones 'apply' rather than 'collect')
> > 
> > Oh... I was confused, thought this was an LLVM patch (since it was sent to llvm-commits) so I was talking about LLVM codegen/asmprinter stuff... 
> > 
> > Nevermind.
> C'mon I did this mailing list mistake again... Sorry for the confusion.
No worries, I'm sure I've done it once or twice.

http://reviews.llvm.org/D6173