[PATCH RESEND 2/3] SelectionDAG: Add KnownBits and SignBits computation for EXTRACT_ELEMENT

Matt Arsenault Matthew.Arsenault at amd.com
Mon Nov 17 11:40:25 PST 2014


On 11/15/2014 02:51 PM, Jan Vesely wrote:
> +    const unsigned index =
> +      cast<ConstantSDNode>(Op.getOperand(1))->getAPIntValue().getLimitedValue();
> +    const unsigned bitwidth = Op.getValueType().getSizeInBits();

Capitalized variable names.

Why getLimitedValue? I think you really want getZExtValue directly from 
the ConstantSDNode



More information about the llvm-commits mailing list