[PATCH] [OCaml] [cmake] Add CMake buildsystem for OCaml.

Chandler Carruth chandlerc at gmail.com
Mon Nov 17 08:43:31 PST 2014


FYI, I'll let Reid finish the review here as he has looked at this in detail.

My only comment is that there is a confusing mixture of indentation styles here (4-space vs. 2-space, etc.). I understand that LLVM's existing CMake isn't the most consistent in this respect, but I think we're increasingly 2-space indent. I would at least try to be consistent with all the cmake bits you're adding here.

http://reviews.llvm.org/D6102






More information about the llvm-commits mailing list