[PATCH] Add VSX loads/stores to fastisel for PPC target
Eric Christopher
echristo at gmail.com
Fri Nov 14 16:23:00 PST 2014
================
Comment at: /home/seurer/llvm/llvm-oneoff/lib/Target/PowerPC/PPCFastISel.cpp:143
@@ +142,3 @@
+ bool isVSXRegister(unsigned Register) const {
+ return ((Register != 0) &&
+ (MRI.getRegClass(Register)->getID() == PPC::VSFRCRegClassID));
----------------
seurer wrote:
> echristo wrote:
> > I'd prefer to pull the Register != 0 out of this so that we can keep the general pattern of checking it. Thoughts?
> If the register is 0 then the call to getRegClass will fail in an assertion. Or rather, another function it calls will fail.
Sure. Make it an assert rather than a check? Should be checking that ResultReg isn't equal to 0 earlier I think.
http://reviews.llvm.org/D6274
More information about the llvm-commits
mailing list