[PATCH] [Thumb/Thumb2] Added restrictions on PC, LR, SP in the register list for PUSH/POP/LDM/STM

Jyoti Allur jyoti.allur at samsung.com
Fri Nov 14 08:45:56 PST 2014


Hi Tim,
I have made some more improvement to the previous patch. Here is a summary of what this patch contains.
Moved all of the register list validation to validateRegListOperands.
We check the conditions for throwing appropriate diagnostic only if the rules in table are rendered false.
listContainsReg removed as we have added findSpecialRegsInList.
Testcases for reglist validation related with SP, PC, LR in /thumb-diagnostics.s
Testcase for ITBlock related validation for LDM/lDMIA,LDMDB in thumb2-diagnostics.s
A testcase in v8_IT_manual.s needed correction after addding this patch due to SP restriction in thumb mode which is valid for v8 as well.

Could you please review it ?

http://reviews.llvm.org/D6090

Files:
  lib/Target/ARM/AsmParser/ARMAsmParser.cpp
  test/MC/ARM/thumb-diagnostics.s
  test/MC/ARM/thumb2-diagnostics.s
  test/MC/ARM/v8_IT_manual.s
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D6090.16216.patch
Type: text/x-patch
Size: 16250 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141114/5b3ee985/attachment.bin>


More information about the llvm-commits mailing list