[patch] Don't make assumptions about the name of private global variables

[Michael Gottesman]

Hey Rafael!

I updated the test as I think is appropriate. I just added some positive tests. Feel free to commit with this test!

-------------- next part --------------
A non-text attachment was scrubbed...
Name: provenance.ll
Type: application/octet-stream
Size: 1480 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141113/8d64e1e1/attachment.obj>
-------------- next part --------------


Michael

> On Nov 11, 2014, at 4:48 PM, Rafael Espíndola <rafael.espindola at gmail.com> wrote:
> 
> OK, I think I have it. The test in the attached patch fails if any of
> the conditions the patch adds are dropped.
> 
> 
> On 11 November 2014 19:00, Michael Gottesman <mgottesman at apple.com> wrote:
>> Ok. Thanks.
>> 
>> Michael
>> 
>>> On Nov 11, 2014, at 3:51 PM, Rafael Espíndola <rafael.espindola at gmail.com> wrote:
>>> 
>>> On 11 November 2014 15:21, Michael Gottesman <mgottesman at apple.com> wrote:
>>>> The simplest and least fragile way to test this is to make a small pass like
>>>> the AAEvaluator that just runs ProvenanceAnalysis::related on all values in
>>>> the function and just prints out a bool value. Then you could just use
>>>> FileCheck to check that the query was successful.
>>>> 
>>>> The other way is to try and create a specific sequence of instructions that
>>>> hopefully will show by how the ARC optimizer moves a release that the query
>>>> is correct.
>>> 
>>> The attached patch includes the pass, but I am still not sure exactly
>>> how to test it :-)
>>> 
>>> Cheers,
>>> Rafael
>>> <t.patch>
>> 
> <t.patch>