[PATCH] Change order of tablegen generated fastisel instruction code to be based on instruction complexity

Eric Christopher echristo at gmail.com
Thu Nov 13 14:27:24 PST 2014


Couple of inline comments.

================
Comment at: /home/seurer/llvm/llvm-oneoff/utils/TableGen/FastISelEmitter.cpp:595
@@ -570,2 +594,3 @@
 
-    SimplePatterns[Operands][OpcodeName][VT][RetVT][PredicateCheck] = Memo;
+// This was used when testing
+//    if (SimplePatterns[Operands][OpcodeName][VT][RetVT].count(complexity)) {
----------------
Is there a reason we either a) don't want this on by default, or b) would never want this on?

================
Comment at: /home/seurer/llvm/llvm-oneoff/utils/TableGen/FastISelEmitter.cpp:648
@@ +647,3 @@
+      if (OneHadNoPredicate) {
+        // FIXME: This sould be a PrintError once the x86 target fixes
+        //     name:VBROADCASTSSZr  predicate: (Subtarget->hasAVX512()) 
----------------
Can you file a bug for this and then link the PR?

http://reviews.llvm.org/D6220






More information about the llvm-commits mailing list