[PATCH] [MSan] [MIPS] Adding support for MIPS64

Alexey Samsonov vonosmas at gmail.com
Thu Nov 13 11:28:51 PST 2014


================
Comment at: lib/msan/msan_report.cc:56
@@ -55,2 +55,3 @@
     // of the first instruction.
-    pc += 1;
+    #if defined(__x86_64__)
+      pc += 1;
----------------
Evgeniy, do we know the reason why this adjustment is needed? Looks like we'd have to use the inverse of StackTrace::GetPreviousInstructionPc() here.

================
Comment at: lib/sanitizer_common/sanitizer_posix.cc:93
@@ -92,1 +92,3 @@
   return (1ULL << 40) - 1;
+# elif defined(__mips64)
+  return (1ULL << 40) - 1;  // 0x000000ffffffffffUL;
----------------
Hm? This looks similar to the previous #elif

http://reviews.llvm.org/D5906






More information about the llvm-commits mailing list