[PATCH] [LIT] Add SuffixDispatchTest for use in libc++ and libc++abi tests.
Dan Albert
danalbert at google.com
Thu Nov 13 11:21:37 PST 2014
================
Comment at: utils/lit/lit/formats/suffixdispatchtest.py:70
@@ +69,3 @@
+
+ # Check that we have the required features.
+ #
----------------
I don't think this TODO should be removed. I read this to mean that `REQUIRES` and `UNSUPPORTED` should be moved into `lit.test` (so they work for any test runner).
================
Comment at: utils/lit/lit/formats/suffixdispatchtest.py:124
@@ +123,3 @@
+ out, err, exit_code, report = lit.util.executeCommandAndReport(cmd,
+ cwd=source_dir)
+ report = 'Compiled With: %s\n' % \
----------------
Alignment.
================
Comment at: utils/lit/lit/util.py:95
----------------
This docstring format will mess with tools.
"""Short, single sentence (usually), description.
Longer description in
paragraph format.
"""
http://reviews.llvm.org/D6206
More information about the llvm-commits
mailing list