[llvm] r221887 - Fixing some sign comparison warnings from MSVC; NFC.

Robinson, Paul Paul_Robinson at playstation.sony.com
Thu Nov 13 09:07:10 PST 2014


Thanks!  Not sure why I didn't notice those.

> -----Original Message-----
> From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-
> bounces at cs.uiuc.edu] On Behalf Of Aaron Ballman
> Sent: Thursday, November 13, 2014 5:40 AM
> To: llvm-commits at cs.uiuc.edu
> Subject: [llvm] r221887 - Fixing some sign comparison warnings from MSVC;
> NFC.
> 
> Author: aaronballman
> Date: Thu Nov 13 07:39:49 2014
> New Revision: 221887
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=221887&view=rev
> Log:
> Fixing some sign comparison warnings from MSVC; NFC.
> 
> Modified:
>     llvm/trunk/unittests/Support/Path.cpp
> 
> Modified: llvm/trunk/unittests/Support/Path.cpp
> URL: http://llvm.org/viewvc/llvm-
> project/llvm/trunk/unittests/Support/Path.cpp?rev=221887&r1=221886&r2=2218
> 87&view=diff
> ==========================================================================
> ====
> --- llvm/trunk/unittests/Support/Path.cpp (original)
> +++ llvm/trunk/unittests/Support/Path.cpp Thu Nov 13 07:39:49 2014
> @@ -425,7 +425,7 @@ TEST_F(FileSystemTest, CreateDir) {
>    size_t TmpLen = TestDirectory.size();
>    const char *OneDir = "\\123456789";
>    size_t OneDirLen = strlen(OneDir);
> -  ASSERT_LT(OneDirLen, 12);
> +  ASSERT_LT(OneDirLen, 12U);
>    size_t NLevels = ((248 - TmpLen) / OneDirLen) + 1;
>    SmallString<260> LongDir(TestDirectory);
>    for (size_t I = 0; I < NLevels; ++I)
> @@ -445,8 +445,8 @@ TEST_F(FileSystemTest, CreateDir) {
>    // TestDirectory so that the one we create ends up in the right place.
>    char PreviousDir[260];
>    size_t PreviousDirLen = ::GetCurrentDirectoryA(260, PreviousDir);
> -  ASSERT_GT(PreviousDirLen, 0);
> -  ASSERT_LT(PreviousDirLen, 260);
> +  ASSERT_GT(PreviousDirLen, 0U);
> +  ASSERT_LT(PreviousDirLen, 260U);
>    ASSERT_NE(::SetCurrentDirectoryA(TestDirectory.c_str()), 0);
>    LongDir.clear();
>    // Generate a relative directory name with absolute length > 248.
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits




More information about the llvm-commits mailing list