[PATCH] Initial commit for the llvm-dsymutil tool.

Frederic Riss friss at apple.com
Wed Nov 12 17:17:37 PST 2014


Hi echristo, dblaikie, kledzik,

This initial version is only able to parse debug maps contained
in mach-o binaries.

Apart from the general review, I'm especially interested in comments
around the build system plumbing.

Nick, the very simple DebugMap object that is present is this version
is meant to be filled with information during the binary link and
then passed to a DwarfLinker object as a separate step. Does that
look like the best flow for you, or would you prefer something more
'incremental'?

The big question around this tool is how the in-tree testing will be
performed. This revision doesn't include a test, but there will be
one in the initial commit. I plan to commit very simple small binaries
for the and then to extend that binary pool when adding new features.
Eevn if I plan to reuse the binaries as much as I can for the various
development steps, I fear that this won't scale in the long run. I'm
open to ideas. Is there some policy about storing binaries in the LLVM
repo?

The current approach has several known shortcomings even for the simple
task it performs. For example, it doesn't handle static libraries, and
it keeps all the object files open at the same time. This initial commit
just provides a base for the incremental updates that will improve that
situation.

http://reviews.llvm.org/D6242

Files:
  tools/Makefile
  tools/dsymutil/CMakeLists.txt
  tools/dsymutil/DebugMap.cpp
  tools/dsymutil/DebugMap.h
  tools/dsymutil/DwarfLinker.cpp
  tools/dsymutil/DwarfLinker.h
  tools/dsymutil/LLVMBuild.txt
  tools/dsymutil/MachODebugMapParser.cpp
  tools/dsymutil/MachODebugMapParser.h
  tools/dsymutil/Makefile
  tools/dsymutil/dsymutil.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D6242.16127.patch
Type: text/x-patch
Size: 19845 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141113/9d3c2108/attachment.bin>


More information about the llvm-commits mailing list