[PATCH] Change order of tablegen generated fastisel instruction code to be based on instruction complexity

Eric Christopher echristo at gmail.com
Wed Nov 12 16:09:47 PST 2014


In general looks good. Couple of inline comments and fixing the bit that Bill pointed out would be nice.

================
Comment at: /home/seurer/llvm/llvm-oneoff/utils/TableGen/FastISelEmitter.cpp:669
@@ -646,1 +668,3 @@
+                               "  predicate: " + PredicateCheck);
+                }
                 OS << "  if (" + PredicateCheck + ") {\n";
----------------
seurer wrote:
> Should this PrintWarning be an PrintError or an assert?  The X86 target actually hits this at least once so perhaps there is some problem there.
This would be nice to track down. What's running into it?

================
Comment at: /home/seurer/llvm/llvm-oneoff/utils/TableGen/FastISelEmitter.cpp:700
@@ +699,3 @@
+            }
+            // Return 0 if none of the predicates were satisfied and there
+            // was not one without a predicate.
----------------
Too many negatives in this comment, could you reword please?

http://reviews.llvm.org/D6220






More information about the llvm-commits mailing list