[PATCH] Fix GraphTraits for "const CallGraphNode *" and "const CallGraph *"

Rafael EspĂ­ndola rafael.espindola at gmail.com
Wed Nov 12 12:38:36 PST 2014


On 12 November 2014 12:55, Speziale Ettore <speziale.ettore at gmail.com> wrote:
> Hello,
>
>> The new patch is quiet a bit bigger, sorry for leading you that way.
>
>
> NP. It was funny to factorize the GraphTraits.
>
>>
>> As for the unit test, I intended for something far smaller. Basically
>> just a test showing that foo and bar in your original email now
>> compile.
>
>
> Added a couple minimal unit tests using static_assert. Without the right
>


Just two nits:

please git-clang-format the patch

template <typename Ty> static void CanSpecializeGraphTraitsIterators(Ty *G) {

Please start new functions with a lowercase letter.

LGTM with that.

Thanks,
Rafael



More information about the llvm-commits mailing list