[PATCH] [ARM] Fix ARM triple parsing.
Renato Golin
renato.golin at linaro.org
Wed Nov 12 09:07:00 PST 2014
REPOSITORY
rL LLVM
================
Comment at: lib/Support/Triple.cpp:270
@@ -237,5 +269,3 @@
.Cases("arm", "xscale", Triple::arm)
- // FIXME: It would be good to replace these with explicit names for all the
- // various suffixes supported.
- .StartsWith("armv", Triple::arm)
+ .StartsWith("armv", parseARMArch(ArchName))
.Case("armeb", Triple::armeb)
----------------
Can't we just say:
.StartsWith("arm", parseARMArch(ArchName))
.StartsWith("thumb", parseARMArch(ArchName))
and add "arm64" to parseARMArch?
Maybe even adding "aarch64" to it, too, and having:
.StartsWith("arm", parseARMArch(ArchName))
.StartsWith("thumb", parseARMArch(ArchName))
.StartsWith("aarch64", parseARMArch(ArchName))
I wonder how Tim/James would feel about that...
http://reviews.llvm.org/D6058
More information about the llvm-commits
mailing list