[PATCH] Change order of tablegen generated fastisel instruction code to be based on instruction complexity

Eric Christopher echristo at gmail.com
Tue Nov 11 16:35:36 PST 2014


>>! In D6220#5, @seurer wrote:
>>>! In D6220#4, @wschmidt wrote:
>> I like this approach.  What did you do to verify the code that's produced for various targets?  (You probably told me this but I've forgotten.)
> 
> I went through some of the generated fastisel .inc files comparing them to a version generated without this change to see if anything stood out as broken.  The ordering is different of course but I am not familiar with the other targets and so I don't know if they are OK or not.  For Power it was all OK.
> 
> I tried to build the X86 target on my laptop to run tests there but I never got it to work.

What problems did you have here? (Though the tests in test/CodeGen/X86 should pass either way)

http://reviews.llvm.org/D6220






More information about the llvm-commits mailing list