[PATCH] We need an OptionStore abstraction for storing debug option data.

Chris Bieneman beanz at apple.com
Mon Nov 10 16:48:35 PST 2014


Hi chandlerc,

The plan was to have the LLVMContext store option data with the new API and not have this abstraction. Unfortunately as I've begin playing with this that isn't possible.

Not having this abstraction actually means we can't parse command line options directly into their storage because LLVMParseCommandLine will never be able to take an LLVMContext as a parameter-- and it shouldn't.

Having the command line parsing code parse into an LLVMContext would mean libLLVMSupport depending on libLLVMCore, which would be a nasty circular dependency. To prevent that we need an abstraction that can be passed into LLVMParseCommandLine, and can be used by libLLVMSupport without requiring libLLVMCore.

http://reviews.llvm.org/D6207

Files:
  include/llvm/IR/LLVMContext.h
  include/llvm/Support/OptionStore.h
  lib/IR/LLVMContext.cpp
  lib/IR/LLVMContextImpl.h
  lib/Transforms/Scalar/Scalarizer.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D6207.16021.patch
Type: text/x-patch
Size: 4713 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141111/9b1d7379/attachment.bin>


More information about the llvm-commits mailing list