[PATCH] PR21482: long paths on Windows

[Robinson, Paul]

Right, I stuck to Path.  Yes there are other places that might want to take this approach.
Assuming UTF8ToUTF16 is a good indicator of where to check, there are maybe a dozen other calls within Support\Windows to look at.  Not all of them are paths so not all of them would have to be changed.
--paulr

From: Reid Kleckner [mailto:rnk at google.com]
Sent: Monday, November 10, 2014 2:12 PM
To: Robinson, Paul
Cc: llvm-commits at cs.uiuc.edu
Subject: Re: [PATCH] PR21482: long paths on Windows

There are many other instances where we pass paths to win32 APIs in lib/Support/Windows, but this seems like a good start.

On Mon, Nov 10, 2014 at 1:01 PM, Robinson, Paul <Paul_Robinson at playstation.sony.com<mailto:Paul_Robinson at playstation.sony.com>> wrote:
Support directory names longer than 248 characters on Windows.

The normal Windows path limit is 260 characters; the limit for directory
names is 248, to leave room for an 8.3 filename at the end.  Adding the
'\\?\' prefix greatly expands these limits.  Intercept path names that
we are about to pass to the Windows APIs and add the prefix if necessary.

Also correct the comment about the state of the temporary directory used
by the Support unittests.
--paulr


_______________________________________________
llvm-commits mailing list
llvm-commits at cs.uiuc.edu<mailto:llvm-commits at cs.uiuc.edu>
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141110/34697f2d/attachment.html>