[lld] r217324 - Remove dead code.

Shankar Easwaran shankare at codeaurora.org
Mon Nov 10 12:34:01 PST 2014


>>>> 2) Add a generic dictionary method to lld::File.  The dictionary might be empty for ELF and COFF readers, but the mach-o reader would populate the dictionary with some key/value encoding for each attribute it needs (e.g. “minOS” —> “10.9”).
>> I would like this, lld::File would become more flavor neutral with this. For example if you add minOS to lld::File it would not make sense for COFF/ELF.
> There will be a default (do nothing) implementation for these methods in the base class File.  COFF and ELF can just ignore them.  The dictionary design is not a normal C++ pattern.
The LLVM IR also uses a metadata/dictionary model, to store attributes 
that are associated with the module. I think we also need a model that 
we can associate metadata with atoms.

Shankar Easwaran

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation




More information about the llvm-commits mailing list