[llvm] r221526 - llvm/test/tools/llvm-symbolizer/ppc64.test: Avoid subshell.

[Jay Foad]

No, problem, thank you for fixing it! I just wanted to understand the rules.

Thanks,
Jay.

On 9 November 2014 00:45, NAKAMURA Takumi <geek4civic at gmail.com> wrote:
> Lit internal runner is missing  subshell and some shell facilities.
> Please be patient when I rewrote tests to satisfy Windows hosts.
>
> Please mark a test as REQUIRES:shell if you really require shell.
>
> 2014-11-09 4:04 GMT+09:00 Jay Foad <jay.foad at gmail.com>:
>> I added this test. Is it forbidden to use subshells in RUN lines?
>>
>> Thanks,
>> Jay.
>>
>> On 7 November 2014 14:50, NAKAMURA Takumi <geek4civic at gmail.com> wrote:
>>> Author: chapuni
>>> Date: Fri Nov  7 08:50:10 2014
>>> New Revision: 221526
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=221526&view=rev
>>> Log:
>>> llvm/test/tools/llvm-symbolizer/ppc64.test: Avoid subshell.
>>>
>>> Modified:
>>>     llvm/trunk/test/tools/llvm-symbolizer/ppc64.test
>>>
>>> Modified: llvm/trunk/test/tools/llvm-symbolizer/ppc64.test
>>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-symbolizer/ppc64.test?rev=221526&r1=221525&r2=221526&view=diff
>>> ==============================================================================
>>> --- llvm/trunk/test/tools/llvm-symbolizer/ppc64.test (original)
>>> +++ llvm/trunk/test/tools/llvm-symbolizer/ppc64.test Fri Nov  7 08:50:10 2014
>>> @@ -4,7 +4,7 @@ int foo() { return 0; }
>>>  int bar() { return foo(); }
>>>  int _start() { return bar(); }
>>>
>>> -RUN: ( echo 0x1000014c ; echo 0x1000018c ; echo 0x100001cc ) | llvm-symbolizer -obj=%p/Inputs/ppc64 | FileCheck %s
>>> +RUN: %python -c "print('0x1000014c\n0x1000018c\n0x100001cc')" | llvm-symbolizer -obj=%p/Inputs/ppc64 | FileCheck %s
>>>
>>>  CHECK: foo
>>>  CHECK: bar
>>>
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits