[PATCH] [test-suite] Make it build in more environments

Sergey Dmitrouk sdmitrouk at accesssoftek.com
Fri Nov 7 05:46:52 PST 2014


Ping.

Also attached one more small patch for shebang in *.tcl files of
sqlite3 test.

Regards,
Sergey

On Tue, Oct 28, 2014 at 09:20:58AM -0700, Sergey Dmitrouk wrote:
> Hello,
> 
> test-suite builds fine on a GNU/Linux machine against glibc and
> other "standard" things, but I also need to build test-suite against
> musl-libc and cross-compile it on Windows.  Making this happen required
> some modifications in test-suite, which generally make it work in a
> wider range of environments.
> 
> I have ten patches so far, it's quite a lot and they are not very
> related.  Sending them separately would basically require ten
> separate emails, but wouldn't make review much easier.  I'll separate
> them if it's preferable.
> 
> A couple of comments:
> 
> 1. There is one huge patch that includes changes in the configure
>    script.  Even using autoconf 2.60 didn't help much, though it reduced
>    number of changed lines by about 25%.
> 2. Some changes are related to escaping.  As I see it no one cares about
>    paths with spaces (no explicit escaping, so it doesn't work), hence
>    new changes shouldn't break anything.
> 
> Please find attached patches.  Most changes are quite trivial, so as
> they are not related to each other, patches that look good can be
> committed while I'm updating those that are not OK (no commit access, so
> please help me with that).
> 
> Best regards,
> Sergey
-------------- next part --------------
commit 7b950e1018bedc70641104ae2810c9bad5e03314
Author: Sergey Dmitrouk <sdmitrouk at accesssoftek.com>
Date:   Fri Nov 7 15:41:48 2014 +0200

    Look for tclsh anywhere in the $PATH for sqlite3
    
    Otherwise test won't work on systems where tclsh is installed at
    different location.

diff --git a/MultiSource/Applications/sqlite3/smalltest.tcl b/MultiSource/Applications/sqlite3/smalltest.tcl
old mode 100644
new mode 100755
index e5acc8b..a74cd63
--- a/MultiSource/Applications/sqlite3/smalltest.tcl
+++ b/MultiSource/Applications/sqlite3/smalltest.tcl
@@ -1,4 +1,4 @@
-#!/usr/bin/tclsh
+#!/usr/bin/env tclsh
 #
 # Run this script using TCLSH to do a speed comparison between
 # various versions of SQLite and PostgreSQL and MySQL
diff --git a/MultiSource/Applications/sqlite3/speedtest.tcl b/MultiSource/Applications/sqlite3/speedtest.tcl
old mode 100644
new mode 100755
index 696f770..372ea7f
--- a/MultiSource/Applications/sqlite3/speedtest.tcl
+++ b/MultiSource/Applications/sqlite3/speedtest.tcl
@@ -1,4 +1,4 @@
-#!/usr/bin/tclsh
+#!/usr/bin/env tclsh
 #
 # Run this script using TCLSH to do a speed comparison between
 # various versions of SQLite and PostgreSQL and MySQL


More information about the llvm-commits mailing list